fix: updates dark theme syntax for Astro + Tailwind support#28
Open
tony-sull wants to merge 1 commit intoone-aalam:mainfrom
Open
fix: updates dark theme syntax for Astro + Tailwind support#28tony-sull wants to merge 1 commit intoone-aalam:mainfrom
tony-sull wants to merge 1 commit intoone-aalam:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for astro-ink ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Owner
|
Hi, @tony-sull Thank you for the PR. Let me get back on this. I'd prefer to keep the current CSS class structure if possible |
Author
|
No problem at all! I kept this one separate from the dependency updates, thought this change might not be wanted 😅 I couldn't find another way to get dark mode to work consistently between Astro's styles and Tailwind dark mode classes, maybe there's a better way though. Happy to close this PR if you'd prefer to keep it as-is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces all remaining uses of
@apply dark:___with inline class namesIt looks like the class names get lost somewhere along the build and Tailwind never recognizes that the
dark:class was used, I'm guessing our compiler may sanitize it todark/:?